[libcxx-commits] [PATCH] D59921: [libunwind] Export the unw_* symbols as weak symbols
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 28 07:31:13 PDT 2019
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Comment at: libunwind/src/Unwind-EHABI.cpp:443
// from scratch thus achieving the same effect.
- unw_init_local(cursor, uc);
+ _unw_init_local(cursor, uc);
I don't think a single leading underscore followed by a lowercase letter is a reserved name (or maybe it is, but only in the global namespace?). I suggest we use two leading underscores for consistency.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits