[libcxx-commits] [PATCH] D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

> Hi, Marshall.
> 
> I've started implementing and testing `to_string` via `to_chars` and realized that `to_chars` doesn't support `wchar_t` unlike `to_wstring`.
>  I'm going to extend `__to_chars_itoa` implementation in order to support `wchar_t` and reuse those internal template function.
> 
> Could you please confirm that this way is ok in order not to through away the third attempt on completion.

I would just use `to_chars` to make a narrow result and then widen it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59178/new/

https://reviews.llvm.org/D59178