[libcxx-commits] [PATCH] D59572: Fix and speedup __libcpp_locale_guard on Windows
Tom Anderson via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 22 19:36:18 PDT 2019
thomasanderson added a comment.
In D59572#1440417 <https://reviews.llvm.org/D59572#1440417>, @EricWF wrote:
> What happens here when the user has different locales for different categories?
Then `__setlocale()` on line 71 will return a string like `"LC_CTYPE=C;LC_MONETARY=en-US;...".` This string will then be fed back into `__setlocale()` on line 85 to restore the categories to what they were.
> That said, this feels like a POSIX-ism we're leaking into our Windows implementation. So I'm open to doing whatever is more Windows-like.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits