[libcxx-commits] [PATCH] D59704: Changed buffer API to receive policy instance.

Thomas Rodgers via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 22 14:10:51 PDT 2019

rodgert added a comment.

In D59704#1439794 <https://reviews.llvm.org/D59704#1439794>, @ldionne wrote:

> I don't see a big problem with this change per-se, but can you please expand on the bit where you say:
> > It may be necessary for the other back-ends, where dynamic memory is not available and custom memory allocator may be provided by a custom policy.
> How would you somehow handle allocation through a custom policy?

Assuming, at some point we figure out how to get p0443 executors and p1019 style execution policy types, which communicate executors to the algorithm, which allocator to use becomes a property query against the executor. The default executor and it's associated properties are a library implementation detail, but the way that the algorithms respond to the presence of those properties should be the same.

Similarly, the execution policy will ultimately need to be communicated to the basis functions of the backend as well, and I am planning on resurrecting my prototype of that change in the next week.

I'd like to be careful about making these sorts of changes until we have had a chance to have the next follow up coordination meeting that Alexey has proposed.

  rPSTL pstl



More information about the libcxx-commits mailing list