[libcxx-commits] [PATCH] D59678: Make common_type's implementation common
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 21 20:21:36 PDT 2019
mclow.lists added inline comments.
Comment at: test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:327
+#if TEST_STD_VER >= 11
+ // Test that we're really variadic in C++11
> mclow.lists wrote:
> > Any reason not to use `ASSERT_SAME_TYPE` in these tests? I find it much easier to read.
> Not really, I was just going with the existing style of the file. Normally I try to write `ASSERT_SAME_TYPE` as well.
My policy these days is that any test I touch gets updated to use `ASSERT_SAME_TYPE` and `ASSERT_NOEXCEPT`.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits