[libcxx-commits] [PATCH] D59619: Allow disabling of filesystem library.
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 20 18:16:04 PDT 2019
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: libcxx/trunk/utils/libcxx/test/config.py:438
+ if not self.get_lit_bool('enable_filesystem', default=True):
> Instead, I think this should be dependent on the platform. I don't see a reason why this would be different from` dylib-has-no-filesystem`.
That information is specified at configure time and the build system should respect that choice. I see no value auto-magically detecting it here. If they don't want it to run, they should disable it at configure time.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits