[libcxx-commits] [PATCH] D59525: Speed up certain locale functions on Windows
Nico Weber via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 20 09:05:35 PDT 2019
thakis added a comment.
In D59525#1435442 <https://reviews.llvm.org/D59525#1435442>, @mclow.lists wrote:
> Thomas - reviews for libc++ must be approved by either @EricWF, @ldionne or myself. None of them approved this.
> Why did you commit it?
https://libcxx.llvm.org has a section saying "Get it and get involved! First please review our Developer's Policy." that links to https://llvm.org/docs/DeveloperPolicy.html That page has a section https://llvm.org/docs/DeveloperPolicy.html#code-reviews that says "Code can be reviewed either before it is committed or after. We expect major changes to be reviewed before being committed, but smaller changes (or changes where the developer owns the component) can be reviewed after commit.". If libcxx's review policy is different from what it's documented as being, consider updating the documentation.
(The next section, https://llvm.org/docs/DeveloperPolicy.html#code-owners , talks about codifying the code owners policy a bit; libcxx should probably have a CODE_OWNERS.txt file like other llvm projects.)
CHANGES SINCE LAST ACTION
More information about the libcxx-commits