[libcxx-commits] [PATCH] D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 20 06:57:16 PDT 2019


mclow.lists added a comment.

In general, I'm not happy with this direction. 
I think it is unwise to have two different implementations of "integer to string" functionality in the library, doing the same thing.
I'm happy with the idea of making `to_string` faster, but not this way.

Also, the only people who are authorized to approve changes for libc++ are: @ldionne, @EricWF and myself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59178/new/

https://reviews.llvm.org/D59178





More information about the libcxx-commits mailing list