[libcxx-commits] [libcxx] r356528 - [libc++] Flag file_clock test as expected to fail with ASAN

[Roman Lebedev via libcxx-commits]

On Wed, Mar 20, 2019 at 12:52 AM Louis Dionne via libcxx-commits
<libcxx-commits at lists.llvm.org> wrote:
>
> Author: ldionne
> Date: Tue Mar 19 14:53:32 2019
> New Revision: 356528
>
> URL: http://llvm.org/viewvc/llvm-project?rev=356528&view=rev
> Log:
> [libc++] Flag file_clock test as expected to fail with ASAN
>
> This silences a known issue, as can be seen by looking at similar
> tests for other clocks, like time.clock.steady/consistency.pass.cpp.
>
> Modified:
>     libcxx/trunk/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp
>
> Modified: libcxx/trunk/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp?rev=356528&r1=356527&r2=356528&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp (original)
> +++ libcxx/trunk/test/std/utilities/time/time.clock/time.clock.file/consistency.pass.cpp Tue Mar 19 14:53:32 2019
> @@ -8,6 +8,10 @@
>  //
>  // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
>
> +// Due to C++17 inline variables ASAN flags this test as containing an ODR
> +// violation because Clock::is_steady is defined in both the dylib and this TU.
Only dylib, or is this a problem for .so too? (is there a asan bugreport?)
I.e. what i'm asking is, should this be "asan && osx" ?

> +// UNSUPPORTED: asan
> +
>  // <chrono>
>
>  // file_clock
Roman.

> _______________________________________________
> libcxx-commits mailing list
> libcxx-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits