[libcxx-commits] [PATCH] D59525: Speed up certain locale functions on Windows

Tom Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 19 13:19:46 PDT 2019

thomasanderson added a comment.

In D59525#1435377 <https://reviews.llvm.org/D59525#1435377>, @smeenai wrote:

> LGTM, though you'll wanna update the commit message.


In D59525#1435389 <https://reviews.llvm.org/D59525#1435389>, @smeenai wrote:

> Unrelated, but out of curiosity: I believe libc++ is set up to require building against the Windows 10 SDK and the Universal CRT right now. For older Windows versions, does Chrome require the Universal CRT to be installed?

No, I believe we statically link the CRT

Comment at: src/support/win32/locale_win32.cpp:96
+#if defined(_LIBCPP_MSVCRT)
+    int result = _vsprintf_s_l( ret, n, format, loc, ap );
smeenai wrote:
> Any reason for preferring this over `_vsnprintf_l`? I think they'll end up being basically equivalent here, except `_vsnprintf_l` is more in line with the else branch.
I just found out about _vsprintf_s_l first.  Changed!



More information about the libcxx-commits mailing list