[libcxx-commits] [PATCH] D59166: Remove exception throwing debug mode handler support.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 18 14:07:31 PDT 2019


ldionne accepted this revision.
ldionne added a comment.

LGTM with inline nit.



================
Comment at: test/support/debug_mode_helper.h:253
+  int exit_code_ = -1;
+  int stdout_pipe_fd[2];
+  int stderr_pipe_fd[2];
----------------
Trailing underscore for member variables?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59166/new/

https://reviews.llvm.org/D59166





More information about the libcxx-commits mailing list