[libcxx-commits] [libcxx] r356153 - [libc++] Do not force building with -fPIC (re-applying)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 14 07:38:38 PDT 2019

Author: ldionne
Date: Thu Mar 14 07:38:38 2019
New Revision: 356153

URL: http://llvm.org/viewvc/llvm-project?rev=356153&view=rev
[libc++] Do not force building with -fPIC (re-applying)

In r355746, we stopped forcing to build with -fPIC because that should
be specified by the CMAKE_POSITION_INDEPENDENT_CODE option at CMake
configure time (and by default -fPIC is used for shared libraries anyways).

However, r355746 had to be reverted in r355756 because we were not
actually building the shared library with -fPIC. The reason is that
we were sharing an object library between the static and the shared
library, which caused flags for static libraries to be used when
building object files that were going to be used for a shared library.

Since this was resolved by r356150, we can stop forcing -fPIC again.

Reviewers: EricWF, smeenai

Subscribers: mgorny, christof, jkorous, dexonsmith, libcxx-commits

Differential Revision: https://reviews.llvm.org/D59250


Modified: libcxx/trunk/lib/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/lib/CMakeLists.txt?rev=356153&r1=356152&r2=356153&view=diff
--- libcxx/trunk/lib/CMakeLists.txt (original)
+++ libcxx/trunk/lib/CMakeLists.txt Thu Mar 14 07:38:38 2019
@@ -105,10 +105,6 @@ if (LIBCXXABI_USE_LLVM_UNWINDER)
 # Setup flags.
-if (NOT WIN32)
-  add_flags_if_supported(-fPIC)

More information about the libcxx-commits mailing list