[libcxx-commits] [PATCH] D58679: Update operator+ for basic_string (P1165R1)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

How do the tests look? Do they need updating to ensure that we have the (new) correct behavior?



================
Comment at: include/string:4168
 
-#endif  // _LIBCPP_CXX03_LANG
+// XXX: I don't think this should be just for _LIBCPP_CXX03_LANG
 
----------------
Yes, it should, because in C++03 we don't have move semantics.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58679/new/

https://reviews.llvm.org/D58679