[libcxx-commits] [PATCH] D59110: Restructure existing test suite to follow libc++ standard layout

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/CMakeLists.txt:3
 
-# TODO(ldionne): This CMake testing infrastructure should be replaced with a
-#                llvm-lit test suite.
+include_directories("${PROJECT_SOURCE_DIR}/include"
+                    ${CMAKE_CURRENT_LIST_DIR})
----------------
I don't understand why we're changing this file. The previous one works just as well, but it does not require adding `CMakeLists.txt`s all over the place in the tree (which just won't scale to the number of tests that will be in the suite).

The next improvement over this should be to run the tests with `lit` (but should be tackled separately).


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59110/new/

https://reviews.llvm.org/D59110