[libcxx-commits] [PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

[Petr Hosek via Phabricator via libcxx-commits]

phosek marked an inline comment as done.
phosek added a comment.

In D59168#1424968 <https://reviews.llvm.org/D59168#1424968>, @smeenai wrote:

> I don't think the duplicated triple is too huge of a deal. I think the layout where the resource directory is moved inside the triple directory is a bit nicer, but I also don't know how much work that change would be and if it's worth it.


One downside is that we would be duplicating Clang resource headers for each target which may not be too big of a deal but something worth mentioning.



================
Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15
 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]"
+// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}clang{{/|\\\\}}x86_64-linux-gnu"
 // CHECK-PER-TARGET-RUNTIME: "-L[[RESDIR]]{{/|\\\\}}x86_64-linux-gnu{{/|\\\\}}lib"
----------------
smeenai wrote:
> Idk if it's worth making this a bit more specific – `clang -###` should print out its InstallerDir, so you could capture that in a FileCheck regex and use it to check the exact path.
I did that in the previous version but that was breaking on Windows and haven't yet figured out how to make it work there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59168/new/

https://reviews.llvm.org/D59168