[libcxx-commits] [PATCH] D59152: [libc++] Build <filesystem> support as part of the dylib
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 8 20:32:46 PST 2019
EricWF added inline comments.
Comment at: libcxx/utils/libcxx/test/config.py:710
- enable_fs = self.get_lit_bool('enable_filesystem', default=False)
- if not enable_fs:
There are going to be users and platforms that don't supply filesystem and wish to disable the tests.
How can they do that?
Comment at: libcxx/utils/libcxx/test/target_info.py:244
- flags += ['-lpthread']
- if not shared_libcxx or enable_fs:
- flags += ['-lrt']
+ flags += ['-lpthread', '-lrt']
flags += ['-lc']
This change seems dangerously incorrect.
When testing the dylib, we don't want to link any libraries not linked by clang by default. Please keep this as it `-lrt` as it was.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits