[libcxx-commits] [PATCH] D58201: Make std::memory_order an enum class (P0439R0)
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 5 08:29:43 PST 2019
zoecarver marked an inline comment as done.
zoecarver added inline comments.
Comment at: include/atomic:613
+ unsigned>::value, "Underlying type differs from unsigned unexpectedly");
> ldionne wrote:
> > `typename` is not needed here, this is not a dependent context.
> Also, you need to wrap the `is_same<underlying_type<...>::type, unsigned>::value` into parenthesis because this will otherwise trip up our `static_assert` emulation. This could have been noticed by running the test suite in c++03 mode with `./build/bin/llvm-lit -sv libcxx/test/std/atomics --param=std=c++03` (assuming a standard CMake setup).
Thanks for fixing this! I will make sure to test C++03 next time. Is there a param to run with GCC?
CHANGES SINCE LAST ACTION
More information about the libcxx-commits