[libcxx-commits] [PATCH] D58852: Changes from integrating PSTL with libstdc++
Thomas Rodgers via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 4 07:56:41 PST 2019
rodgert added a comment.
In D58852#1416945 <https://reviews.llvm.org/D58852#1416945>, @ldionne wrote:
> Do you think you could split this change into smaller changes? Perhaps one that removes the support for the Makefile tests, one that introduces forward declarations, and one that renames the test suite files?
I tried to git rebase --interactive my way into something along those lines, but the series of commits which were squashed into this one made the process fairly messy. I can certainly split this one into two changes though, one that introduces the forward declarations (it also removes some unused includes), and one that simultaneously deprecates the support for the Makefile tests and reintroduces them with the new structure. Would that work for you?
CHANGES SINCE LAST ACTION
More information about the libcxx-commits