[libcxx-commits] [PATCH] D63230: Add observer_ptr

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 7 inline comments as done.
zoecarver added inline comments.


================
Comment at: include/experimental/memory:49
+
+#include <type_traits>
+#include <functional>
----------------
EricWF wrote:
> The first include should always be either `<__config>`, or when in experimental, `<experimental/__config>`.
Good to know, thanks.


================
Comment at: include/experimental/memory:62
+
+_LIBCPP_BEGIN_NAMESPACE_STD // TODO: use _LIBCPP_BEGIN_NAMESPACE_LFTS?
+
----------------
EricWF wrote:
> Yes. You *cannot* add additional symbols to namespace `std`
You're right. That is what the standard says. I was confused by the paper. 


================
Comment at: include/experimental/memory:67
+{
+    typedef add_pointer_t<_Wp>          pointer;
+    typedef add_lvalue_reference_t<_Wp> reference;
----------------
EricWF wrote:
> These should be reserved names if they're not part of the spec.
Based on 2516 it was unclear to me whether these should still exist or should be mangled. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230