[libcxx-commits] [PATCH] D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available.

[Richard Smith - zygoloid via Phabricator via libcxx-commits]

rsmith added inline comments.


================
Comment at: libcxx/include/__hash_table:1009
     __compressed_pair<float, key_equal>                   __p3_;
+    #define __first_node_      __p1_.first()
+    #define __size_            __p2_.first()
----------------
EricWF wrote:
> I really don't like this `#define` approach. Perhaps we could create accessor functions instead?
OK. This will re-add some compilation overhead to the new mode that I was trying to eliminate, but it should be no more than we pay in the old mode. I certainly don't have any measurements to justify this ugliness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63744/new/

https://reviews.llvm.org/D63744