[libcxx-commits] [PATCH] D60480: [libc++] Integrate the PSTL into libc++

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/lib/CMakeLists.txt:125
 
+find_package(ParallelSTL)
+if (NOT TARGET pstl::ParallelSTL)
----------------
MikeDvorskiy wrote:
> ldionne wrote:
> > The basic idea is that when `ParallelSTL` is installed on the system (or if it's in the tree), we just find it with `find_package` and then declare a dependency on it and everything should work.
> > ParallelSTL is installed on the system
> 
> What does it mean? The fact there is no ParallelSTL as "product/component". ParallelSTL - just a set of headers.
> 
> So, the cmake file should find "ParallelSTL package".
> 
Either it's in the tree and we can find it (like we do here), or it's somewhere on the system and has a `ParallelSTLConfig.cmake` file installed alongside it (which our current pstl build does install). Realistically, I only expect the former to be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60480/new/

https://reviews.llvm.org/D60480