[libcxx-commits] [PATCH] D60480: [libc++] Integrate the PSTL into libc++

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxxabi/src/CMakeLists.txt:149
 endif()
 
+find_package(ParallelSTL)
----------------
ldionne wrote:
> EricWF wrote:
> > Why does libc++abi depend on parallel algorithms? That seems backwards?
> Yes, it is. It's because libc++abi includes headers from libc++ that pull in the parallel algorithms when they're enabled. So this is needed to support building libc++abi against a libc++ that has the parallel algorithms enabled.
This is a layering violation and creates a circular dependency. I don't think we can or should structure the project like this.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60480/new/

https://reviews.llvm.org/D60480