[libcxx-commits] [PATCH] D62228: Make `vector` unconditionally move elements when exceptions are disabled.

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 21 04:19:57 PDT 2019


EricWF updated this revision to Diff 205965.
EricWF added a comment.

Sorry, I think the previous patch was misleading. My ambitions don't extend beyond this small performance fix. There are no other places in libc++ that conditionally move.

I've removed `__extended_move_if_noexcept` because we've agreed the general abstraction it implements isn't what we want and isn't good generally.

Is this localized performance fix more acceptable? I don't think it violates the spirit of the previous conversation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62228/new/

https://reviews.llvm.org/D62228

Files:
  include/memory
  include/vector
  test/libcxx/containers/sequences/vector/exception_safety_exceptions_disabled.sh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62228.205965.patch
Type: text/x-patch
Size: 5589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190621/ef883a9a/attachment.bin>


More information about the libcxx-commits mailing list