[libcxx-commits] [PATCH] D63296: [libc++] Fix build with gcc 4.8

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 13 14:45:13 PDT 2019


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This change is OK.

But the reason behind it is concerning, because libc++ doesn't support these compilers. Things will break again in the future, and they won't be cleaned up.

GCC 4.8 is not enough of a C++11 compiler to tolerate libc++. We've always had to use 4.9 as the baseline GCC.
We now require 5.1, and I'm planning on pushing for the stricter requirement of only supporting the last three major versions of GCC or Clang.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63296/new/

https://reviews.llvm.org/D63296





More information about the libcxx-commits mailing list