[libcxx-commits] [PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: include/variant:1128
+template <class... _Types>
+struct __overload<bool const volatile, _Types...>
+    : __overload_bool<__overload<_Types...>, bool const volatile> {};
----------------
EricWF wrote:
> Do we even support volatile types in variant?
[[ http://eel.is/c++draft/variant.variant#2 | Yes. ]]

> All types in Types shall be (possibly cv-qualified) object types that are not arrays.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44865/new/

https://reviews.llvm.org/D44865