[libcxx-commits] [PATCH] D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double

[Xing Xue via Phabricator via libcxx-commits]

xingxue marked 4 inline comments as done.
xingxue added a comment.

Thanks Marshall and Hurbert for your comments!



================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:91
+#else
+    bool skipTest = false;
+#endif
----------------
mclow.lists wrote:
> This is all compile-time stuff; we shouldn't be doing a runtime check.
> Also, in other places we check `#if defined(__PPC__)` not just `#if __PPC__`
> 
Changed to skip the test without a runtime check.  Use `#if defined(__PPC__)` as suggested.


================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:114
+        assert(res <= d2);
+    } else {
+        std::cerr
----------------
mclow.lists wrote:
> We don't usually write outputs in tests; no one looks at them.
Removed the output.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62384/new/

https://reviews.llvm.org/D62384