[libcxx-commits] [PATCH] D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

I'd like to understand what's going on with `nextafter` when you say "is unreliable". Is there a link describing this behavior?



================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:91
+#else
+    bool skipTest = false;
+#endif
----------------
This is all compile-time stuff; we shouldn't be doing a runtime check.
Also, in other places we check `#if defined(__PPC__)` not just `#if __PPC__`



================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:114
+        assert(res <= d2);
+    } else {
+        std::cerr
----------------
We don't usually write outputs in tests; no one looks at them.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62384/new/

https://reviews.llvm.org/D62384