[libcxx-commits] [PATCH] D65004: [libc++] Unconditionally enable module tests when they're supported
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jul 29 14:42:18 PDT 2019
EricWF added inline comments.
================
Comment at: libcxx/utils/libcxx/test/config.py:1014
['-fmodules-cache-path=' + module_cache]
- if enable_modules:
- self.config.available_features.add('-fmodules')
- self.cxx.useModules()
+ self.config.available_features.add('-fmodules')
+ self.cxx.useModules()
----------------
This doesn't enable the "module tests". That's done above when "modules-support" is added. This code enables using modules for *every test in the testsuite*.
Although it makes the test suite run a lot faster, I'm not sure we want to enable it by default. We at least need some buildbots that test non-modular configurations.
Is turning modules on all the time the intent of your patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65004/new/
https://reviews.llvm.org/D65004
More information about the libcxx-commits
mailing list