[libcxx-commits] [PATCH] D64818: [libcxx] Construct path using a instance of std::locale

Jean Guegant via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 16 13:48:24 PDT 2019


jguegant added a comment.

Note: this is my first contribution to libc++. I tried to follow the style used in the rest of files, but I may have missed some hidden coding style rules: some files use four spaces, some two? Which SFINAE pattern (return type, class paramter...) is to be preferred? Free template functions vs template classes with static member functions?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64818/new/

https://reviews.llvm.org/D64818





More information about the libcxx-commits mailing list