[libcxx-commits] [Diffusion] rL365847: Attempt to override broken buildbot config for libc++abi.

Peter Collingbourne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 12 14:07:01 PDT 2019


pcc added subscribers: libcxx-commits, pcc.
pcc added a comment.

This change broke the fuzzer libc++ build on multiple sanitizer buildbots, e.g.:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22287
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/13081

You can reproduce by patching out the `$USER` check:

  diff --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt
  index fd74c2742e0..339fb8d200f 100644
  --- a/libcxx/CMakeLists.txt
  +++ b/libcxx/CMakeLists.txt
  @@ -150,10 +150,8 @@ set_property(CACHE LIBCXX_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
   # FIXME: This is a temporary hack to get the buildbots working while D63883 is in flight.
   # Without this all the bots fail while building libc++
   if (DEFINED ENV{USER})
  -  if (("$ENV{USER}" STREQUAL "buildbot") OR (("$ENV{USER}" STREQUAL "llvmbb") OR ("$ENV{USER}" STREQUAL "buildslave")))
       message(WARNING "OVERRIDING BUILDBOT CONFIG")
       set(LIBCXX_CXX_ABI "default" CACHE STRING "FIXME" FORCE)
  -  endif()
   endif()
   # Setup the default options if LIBCXX_CXX_ABI is not specified.
   if (LIBCXX_CXX_ABI STREQUAL "default")

and doing:

  $ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_PARALLEL_LINK_JOBS=20 -DLLVM_ENABLE_PROJECTS='clang;lld;lldb;compiler-rt' ../llvm
  $ projects/compiler-rt/lib/fuzzer/libcxx_fuzzer_i386-stamps/libcxx_fuzzer_i386-build


Users:
  EricWF (Author)

https://reviews.llvm.org/rL365847





More information about the libcxx-commits mailing list