[libcxx-commits] [PATCH] D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 11 08:33:00 PDT 2019


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Fine with this if @Bigcheese is, however I'd like this patch to include a change to the `LIBCXXABI_ENABLE_EXCEPTIONS` CMake option, which controls whether `_LIBCXXABI_NO_EXCEPTIONS` is defined. The option currently says `"Use exceptions."`, however it should say something along the lines of: `"Provide support for exceptions in the runtime. When this is disabled, libc++abi does not support stack unwinding and other exceptions-related features"`.


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64191/new/

https://reviews.llvm.org/D64191





More information about the libcxx-commits mailing list