[libcxx-commits] [PATCH] D64105: libc++: add _LIBCPP_HAS_NO_LONG_DOUBLE
JF Bastien via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jul 2 14:55:33 PDT 2019
jfb added inline comments.
================
Comment at: libcxx/include/math.h:789
+#if !(defined(_AIX) || defined(__sun__) || defined(__ASYLO__))
inline _LIBCPP_INLINE_VISIBILITY long double
----------------
deeglaze wrote:
> jfb wrote:
> > These seem unfortunate. Can you look at the history to see why there's no feature macro that explains with?
> It's not a uniform feature for Sun and AIX, as you can see further down for declarations like asinh. The sun support came 4 years ago in fbbfd092 for cmath, since math.h split from cmath after that. The AIX support was 6 years ago in 5d1a701, which seems slightly entangled with Microsoft's C runtime (_LIBCPP_MSVCRT). I'm not familiar enough with this codebase to suggest a feature strategy to overcome these unexpectedly non-uniform distinctions.
Ugh yeah that sounds like a mess not worth touching in this patch. Thanks for looking into it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64105/new/
https://reviews.llvm.org/D64105
More information about the libcxx-commits
mailing list