[libcxx-commits] [PATCH] D57496: Specify unwind lib before other system libraries.
Yuanfang Chen via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jan 30 20:17:24 PST 2019
tabloid.adroit created this revision.
tabloid.adroit added reviewers: phosek, ldionne, EricWF.
Herald added subscribers: libcxx-commits, christof, mgorny.
This matters on OSX because static linking orders is also the order dyld uses to search for libs(the default - Two-level namespace).
If system libs (including unwind lib) are specified before local unwind lib, local unwind lib would never be picked up by dyld.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D57496
Files:
src/CMakeLists.txt
Index: src/CMakeLists.txt
===================================================================
--- src/CMakeLists.txt
+++ src/CMakeLists.txt
@@ -189,7 +189,7 @@
if(COMMAND llvm_setup_rpath)
llvm_setup_rpath(cxxabi_shared)
endif()
- target_link_libraries(cxxabi_shared PRIVATE ${LIBCXXABI_LIBRARIES} ${LIBCXXABI_SHARED_LIBRARIES})
+ target_link_libraries(cxxabi_shared PRIVATE ${LIBCXXABI_SHARED_LIBRARIES} ${LIBCXXABI_LIBRARIES})
set_target_properties(cxxabi_shared
PROPERTIES
CXX_EXTENSIONS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57496.184445.patch
Type: text/x-patch
Size: 559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190131/e74ad76d/attachment.bin>
More information about the libcxx-commits
mailing list