[libcxx-commits] [PATCH] D57351: [libc++] Explicitly initialize std::nothrow

Tom Anderson via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 30 11:22:58 PST 2019


On Wed, Jan 30, 2019 at 11:11 AM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> Does not seem to have been reviewed; and again, no lists subscribed.
>

Sorry about that, please feel free to revert.  I changed the CL to the
inline comment suggested by the reviewer so I thought it would have their
approval and this change just got lost in their inbox.
Also which lists need to be added?

On Wed, Jan 30, 2019 at 10:09 PM Tom Anderson via Phabricator via
> libcxx-commits <libcxx-commits at lists.llvm.org> wrote:
> >
> > This revision was not accepted when it landed; it landed in state "Needs
> Review".
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rCXX352648: [libc++] Explicitly initialize std::nothrow
> (authored by thomasanderson, committed by ).
> > Herald added subscribers: libcxx-commits, ldionne.
> >
> > Repository:
> >   rCXX libc++
> >
> > CHANGES SINCE LAST ACTION
> >   https://reviews.llvm.org/D57351/new/
> >
> > https://reviews.llvm.org/D57351
> >
> > Files:
> >   src/new.cpp
> >
> >
> > Index: src/new.cpp
> > ===================================================================
> > --- src/new.cpp
> > +++ src/new.cpp
> > @@ -34,7 +34,7 @@
> >  {
> >
> >  #ifndef __GLIBCXX__
> > -const nothrow_t nothrow = {};
> > +const nothrow_t nothrow{};
> >  #endif
> >
> >  #ifndef LIBSTDCXX
> >
> >
> > _______________________________________________
> > libcxx-commits mailing list
> > libcxx-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190130/1c217a58/attachment.html>


More information about the libcxx-commits mailing list