[libcxx-commits] [PATCH] D56500: [libcxx] Fix order checking in unordered_multiset tests.

[Andrey Maksimov via Phabricator via libcxx-commits]

amakc11 added a comment.

> Wouldn't it be enough (and simpler) to do something like this

No, it definitely wouldn't. The proposed simplification throws the baby out with the bathwater and lowers the testing value of the code. Both the original and the patched code effectively test these requirements <http://eel.is/c++draft/unord.req#6> of the standard. The simplified code lacks the check of the following requirement: "In containers that support equivalent keys, elements with equivalent keys are adjacent to each other in the iteration order of the container".

> I find the proposed patch difficult to follow.

It is not the difficulty of the testing code that should matter, but its effectiveness and completeness called "test coverage". Тhe more you sweat in testing the less you bleed in application.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56500/new/

https://reviews.llvm.org/D56500