[libcxx-commits] [PATCH] D56662: The test coverage extension: the other order of includes of the key headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 28 12:04:54 PST 2019


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I like that we're adding test coverage, but I think we should add a dedicated test for that instead of just testing it as a byproduct of another test. Could you please create a new source file that checks specifically for this?


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56662/new/

https://reviews.llvm.org/D56662





More information about the libcxx-commits mailing list