[libcxx-commits] [PATCH] D57262: [libunwind] Drop the dependency on <algorithm>, add placement new inline

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 25 16:11:31 PST 2019


phosek added a comment.

In D57262#1372004 <https://reviews.llvm.org/D57262#1372004>, @mcgrathr wrote:

> Should you add `-nostdinc++` to the compilation flags to drive home that this code can't depend on any library headers?


Done, we were already using `-nostdinc++` but we were also adding libc++ include path explicitly into the list of include directories, so I dropped that logic and made `-nostdinc++` unconditional.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57262/new/

https://reviews.llvm.org/D57262





More information about the libcxx-commits mailing list