[libcxx-commits] [libcxx] r351670 - Fix aligned allocation availability XFAILs after D56445.

Wed Jan 23 13:11:44 PST 2019

Merged to 8.0 in r351980.

On Sat, Jan 19, 2019 at 5:21 PM Eric Fiselier via libcxx-commits
<libcxx-commits at lists.llvm.org> wrote:
>
>
>
>
> ---------- Forwarded message ----------
> From: Eric Fiselier <eric at efcs.ca>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Sun, 20 Jan 2019 01:21:35 -0000
> Subject: [libcxx] r351670 - Fix aligned allocation availability XFAILs after D56445.
> Author: ericwf
> Date: Sat Jan 19 17:21:35 2019
> New Revision: 351670
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351670&view=rev
> Log:
> Fix aligned allocation availability XFAILs after D56445.
>
> D56445 bumped the minimum Mac OS X version required for aligned
> allocation from 10.13 to 10.14. This caused libc++ tests depending
> on the old value to break.
>
> This patch updates the XFAILs for those tests to include 10.13.
>
> Modified:
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp
>     libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -16,9 +16,11 @@
>  // None of the current GCC compilers support this.
>  // UNSUPPORTED: gcc-5, gcc-6
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13.
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -14,9 +14,11 @@
>  // FIXME change this to XFAIL.
>  // UNSUPPORTED: no-aligned-allocation && !gcc
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13.
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -14,9 +14,11 @@
>  // FIXME turn this into an XFAIL
>  // UNSUPPORTED: no-aligned-allocation && !gcc
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13.
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -9,9 +9,11 @@
>  // UNSUPPORTED: c++98, c++03, c++11, c++14
>  // UNSUPPORTED: sanitizer-new-delete
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13.
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -15,9 +15,11 @@
>  // None of the current GCC compilers support this.
>  // UNSUPPORTED: gcc-5, gcc-6
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -8,9 +8,11 @@
>
>  // UNSUPPORTED: c++98, c++03, c++11, c++14
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13.
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -8,9 +8,11 @@
>
>  // UNSUPPORTED: c++98, c++03, c++11, c++14
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp?rev=351670&r1=351669&r2=351670&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp (original)
> +++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp Sat Jan 19 17:21:35 2019
> @@ -9,9 +9,11 @@
>  // UNSUPPORTED: c++98, c++03, c++11, c++14
>  // UNSUPPORTED: sanitizer-new-delete
>
> -// Aligned allocation was not provided before macosx10.12 and as a result we
> -// get availability errors when the deployment target is older than macosx10.13.
> -// However, AppleClang 10 (and older) don't trigger availability errors.
> +// Aligned allocation was not provided before macosx10.14 and as a result we
> +// get availability errors when the deployment target is older than macosx10.14.
> +// However, AppleClang 10 (and older) don't trigger availability errors, and
> +// Clang < 8.0 doesn't warn for 10.13
> +// XFAIL: !(apple-clang-9 || apple-clang-10 || clang-7) && availability=macosx10.13
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.12
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.11
>  // XFAIL: !(apple-clang-9 || apple-clang-10) && availability=macosx10.10
>
>
>
>
>
> ---------- Forwarded message ----------
> From: Eric Fiselier via libcxx-commits <libcxx-commits at lists.llvm.org>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Sat, 19 Jan 2019 17:21:37 -0800 (PST)
> Subject: [libcxx-commits] [libcxx] r351670 - Fix aligned allocation availability XFAILs after D56445.
> _______________________________________________
> libcxx-commits mailing list
> libcxx-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits