[PATCH] D56983: [libunwind] Add casts to avoid warnings about implicit conversions losing precision

Tue Jan 22 08:16:10 PST 2019

mstorsjo added a comment.

In D56983#1366300 <https://reviews.llvm.org/D56983#1366300>, @ldionne wrote:

> I'm not really familiar with this code -- can you quickly explain why it's OK to lose precision here? Mostly for my education.

The LocalAddressSpace class has got a `getRegister` method that returns `uint64_t`, while this method returns a variable sized to the actual size of registers on the current architecture. I.e. this fixes warnings on 32 bit architectures.

Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56983/new/

https://reviews.llvm.org/D56983