[PATCH] D56139: [pstl] Fix compile errors when PARALLEL_POLICIES is disabled

Tue Jan 22 07:45:06 PST 2019

ldionne added inline comments.

================
Comment at: include/pstl/internal/algorithm_impl.h:181

 template <class _ExecutionPolicy, class _RandomAccessIterator, class _Size, class _Function, class _IsVector>
 _RandomAccessIterator
----------------
rodgert wrote:
> Shouldn't this definition be protected by #ifdef __PSTL_USE_PAR_POLICIES?
> 
> Sure, it will fail to compile because it calls something that is __PSTL_USE_PAR_POLICIES but what was it ldionne said about being consistent recently?
I don't understand your comment. What is inconsistent about `pattern_walk1_n` not being guarded by `#ifdef __PSTL_USE_PAR_POLICIES`? Sorry, just trying to understand.

FWIW, I think that removing code based on `__PSTL_USE_PAR_POLICIES` is a misfeature and we should find a more gracious way of handling the lack of parallel policies, for example by having a backend that does everything sequentially if that makes sense. I accepted this revision because it fixed a compilation error under a configuration that currently seems to be supported.

Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56139/new/

https://reviews.llvm.org/D56139