[PATCH] D56979: [libcxxabi] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

Martin Storsjö via Phabricator reviews at reviews.llvm.org
Sun Jan 20 23:17:23 PST 2019


mstorsjo added a comment.

In D56979#1364855 <https://reviews.llvm.org/D56979#1364855>, @EricWF wrote:

> Does libc++ need a similar change?


No - for reasons I'm not familiar with entirely, libc++ doesn't include HandleLLVMOptions. The last commit where HandleLLVMOptions was included was SVN r243591 ("Attempt to fix build issues introduced by r243574"), while it was gone in SVN r243593 ("Revert recent CMake changes again due to failing compiler-rt builds"). However libunwind needs the same (D56981 <https://reviews.llvm.org/D56981>).


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56979/new/

https://reviews.llvm.org/D56979





More information about the libcxx-commits mailing list