[PATCH] D56676: Introduce forward definitions

[Alexey Kukanov via Phabricator]

akukanov added a comment.

As I understand, this patch adds forward declarations for all internal functions, similarly to "defs" files having declarations for all functions in `namespace std`. Perhaps the file names should be aligned with the existing files, e.g. `glue_algorithm_internal_defs.h` etc.

Also the new files are not included anywhere. Will there be a separate patch that uses these files, or they are intended solely for integration into C++ libraries (or even solely libstdc++)? If the latter, perhaps a usage example could be documented somewhere - in the comments or maybe in a separate readme-like file.



================
Comment at: include/pstl/internal/parallel_backend_tbb_fwd.h:11
+
+#ifndef __PSTL_parallel_backend_tbb_fwd_H
+#define __PSTL_parallel_backend_tbb_fwd_H
----------------
The backend API was supposed to be implementation independent. Maybe there should be no "tbb" in the file name?


================
Comment at: include/pstl/internal/parallel_backend_tbb_fwd.h:47-50
+struct backend_impl_t
+{
+    static cancel_execution();
+};
----------------
Currently, `cancel_execution()` is a standalone function in namespace `par_backend`. Is this mismatch intentional or accidental?


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56676/new/

https://reviews.llvm.org/D56676