[PATCH] D56503: [libcxx] Portability fix: add missing includes.

Andrey Maksimov via Phabricator reviews at reviews.llvm.org
Mon Jan 14 11:00:39 PST 2019


amakc11 added inline comments.


================
Comment at: test/std/input.output/stream.buffers/streambuf/streambuf.virtuals/streambuf.virt.get/xsgetn.pass.cpp:19
 #include <cassert>
+#include <string.h>
 
----------------
EricWF wrote:
> `<cstring>` instead?
Why? Please, provide reasoning in the context of this very test. My reasoning, for example, is: in standard `<string.h>` defines `strcmp()`, `<cstring>` defines `std::strcmp()`, this very test uses the first variant of the function call.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56503/new/

https://reviews.llvm.org/D56503





More information about the libcxx-commits mailing list