[PATCH] D56494: Implement the `sys_time` portions of the C++20 calendaring stuff
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Thu Jan 10 12:55:18 PST 2019
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
I've only had time to do a cursory review, but LGTM so far.
================
Comment at: include/chrono:2431
+ };
+ return month() != February || !__y.is_leap() ?
+ __d[static_cast<unsigned>(month()) - 1] : chrono::day{29};
----------------
Mostly a nitpick, but I would find this clearer:
```
month() == February && __y.is_leap() ? chrono::day{29} : __d[static_cast<unsigned>(month()) - 1]
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56494/new/
https://reviews.llvm.org/D56494
More information about the libcxx-commits
mailing list