[PATCH] D56398: Add new EINTEGRITY errno

Marshall Clow via Phabricator reviews at reviews.llvm.org
Thu Jan 10 11:05:48 PST 2019


mclow.lists added inline comments.


================
Comment at: include/errno.h:36
 
-#if !defined(EOWNERDEAD) || !defined(ENOTRECOVERABLE)
+#if !defined(EOWNERDEAD) || !defined(ENOTRECOVERABLE) || !defined(EINTEGRITY)
 
----------------
This chunk of ifdefs more than tripled in size when we went from "two possible additions" to "three possible additions". What happens when someone adds a fourth?

"Not sustainable" is the kindest thing I can say about this.



Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56398/new/

https://reviews.llvm.org/D56398





More information about the libcxx-commits mailing list