[PATCH] D56026: [libcxxabi] Support building hermetic static library

[Louis Dionne via Phabricator]

ldionne added inline comments.


================
Comment at: libcxxabi/src/CMakeLists.txt:185
+  if(LIBCXXABI_HERMETIC_STATIC_LIBRARY)
+    add_library(cxxabi_shared SHARED $<TARGET_OBJECTS:cxxabi_shared_objects>)
+  else()
----------------
Does it make any sense to have `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXXABI_ENABLE_SHARED` at the same time? I don't understand why we're creating a target named `cxxabi_shared` when `LIBCXXABI_HERMETIC_STATIC_LIBRARY` is true.


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56026/new/

https://reviews.llvm.org/D56026