[PATCH] D55840: P0722R3: Implement library support for destroying delete

Mon Jan 7 08:10:08 PST 2019

mclow.lists added a comment.

This is going to need some work before landing.

- The feature test macro should be defined in `<version>`, not in `<new>`
- Testing for the feature-test macro should go into the feature test stuff; look in test/std/language.support/support.limits/support.limits.general.

- Should we have a libc++ macro `_LIBCPP_HAS_NO_DESTROYING_DELETE`, which gets defined in `<config>`, and then used in `<new>`? [ I am unsure; if there was a new replaceable overload of `operator delete` then I would say "absolutely". ]

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55840/new/

https://reviews.llvm.org/D55840