[PATCH] D56064: More tolerance for flaky tests in libc++ on NetBSD

Sat Jan 5 15:48:05 PST 2019

EricWF added a comment.

In D56064#1347397 <https://reviews.llvm.org/D56064#1347397>, @krytarowski wrote:

> In D56064#1347394 <https://reviews.llvm.org/D56064#1347394>, @EricWF wrote:
>
> > I would rather revert this, and fix the flaky tests. And if there are flaky tests that aren't marked flaky then we need to do that.
>
>
> Do you volunteer to monitor the buildbot for flaky reports?

I'm always watching the buildbots when I commit and when I see flaky tests I attempt to fix or improve them.

I want each flaky test documented with `// FLAKY_TEST` and we should always attempt to fix a flaky test before we adjust the test suite to tolerate it.
This patch make it much easier to write flaky tests without knowledge or documentation.

PS. If you're running into constant flakes in the threading tests, try passing `--shuffle` to prevent all the thread hungry tests from being run together.

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56064/new/

https://reviews.llvm.org/D56064