[libcxx-commits] [PATCH] D58642: Second part of P1227R2 - Signed ssize() functions, unsigned size() functions

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 26 16:50:01 PST 2019


mclow.lists added inline comments.


================
Comment at: libcxx/include/iterator:1868
+template <class _Cont>
+inline _LIBCPP_INLINE_VISIBILITY
+constexpr auto ssize(const _Cont& __c)
----------------
mclow.lists wrote:
> ldionne wrote:
> > Is there a reason for making this `inline`? Templates are already `inline` by default.
> Nope; I'll remove it.
> 
All "the rest of these" (`size`,`data`, `empty`, etc) are `inline _LIBCPP_INLINE_VISIBILITY`. I left these new ones the same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58642/new/

https://reviews.llvm.org/D58642





More information about the libcxx-commits mailing list