[libcxx-commits] [PATCH] D58642: Second part of P1227R2 - Signed ssize() functions, unsigned size() functions

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 26 16:50:00 PST 2019


mclow.lists updated this revision to Diff 188478.
mclow.lists marked an inline comment as done and an inline comment as not done.
mclow.lists added a comment.

Update based on Louis' comments.
Make `std::ssize` conditionally noexcept.
Leave it as `inline _LIBCPP_INLINE_VISIBILITY`

Update the `ssize` tests to check the noexcept-ness.
Update the  `size` tests to check the noexcept-ness.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58642/new/

https://reviews.llvm.org/D58642

Files:
  libcxx/include/iterator
  libcxx/test/std/iterators/iterator.container/size.pass.cpp
  libcxx/test/std/iterators/iterator.container/ssize.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58642.188478.patch
Type: text/x-patch
Size: 5990 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190227/9fb05571/attachment.bin>


More information about the libcxx-commits mailing list